refactor(components): make title optional in ContentOverlay#2942
Closed
chris-at-jobber wants to merge 121 commits intomasterfrom
Closed
refactor(components): make title optional in ContentOverlay#2942chris-at-jobber wants to merge 121 commits intomasterfrom
chris-at-jobber wants to merge 121 commits intomasterfrom
Conversation
…ttom sheet and keyboard positioning
…rop in BottomSheet
…bottom-sheet-and-replace-react-native-modalize' into JOB-140606-implement-it-in-content-overlay
We realized this file is actually exported as part of our package, so that's why reanimated's mock was duplicated between this file and __mocks.ts.
Restored that and moved `require("react-native-reanimated").setUpTests()` to our __mocks.ts file.
remove erroneous documenation
* deprecate legacy prop * update props * fully removed unused props
* uninstall modalize * sync lockfile with npm i * remove Modalize reference in override
* add ContentOverlayProvider, integrate with InputText to handle keyboard interactions * avoid TS error, fix mock, add keyboard config props * remove redundant test * use interactive to prevent issues when no snap points * prevent drag/pan in new way, always provide snap points to fix keyboard dismiss restoration * add context for our single snap point entry * use simpler callback for onClose * add a couple tests * handle large screen modal flow * remove unnecessary ContentOverlay useEffect * update draggable logic and comments * replace provider in tests * remove low value tests
…rity (#2884) * add behavior computation module with tests, implement in ContentOverlay * clean up tests * update spelling for consistency * update logic to mirror existing * revert back to position for top logic
…oller (#2889) * add RNKC, use to fix SV issues in ContentOverlay * prevent ts errors in mocks * provide override for RNKC package * add additional mocks for site * add aliases for RN packages to avoid vite failures * revert aliases, use exernal instead * surgically correct package-lock state * update package-lock dep locations
Deploying atlantis with
|
| Latest commit: |
6a89642
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5d55c22d.atlantis.pages.dev |
| Branch Preview URL: | https://make-title-optional-in-conte.atlantis.pages.dev |
|
Published Pre-release for 6a89642 with versions: To install the new version(s) for Web run: To install the new version(s) for Mobile run: |
Base automatically changed from
JOB-140606-implement-it-in-content-overlay
to
master
March 30, 2026 14:28
Contributor
Author
|
Michael got this sorted 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations
For cases where a consumer may want to provide their own title, or NO title, the title prop can be optional (similar to the Modal component in web, or the BottomSheet component in mobile).
When a title is not passed and there is no dismiss option, the header section should be empty and not take up vertical space within the ContentOverlay.
Changes
Changed
titleproperty optional and updated the renderHeader to account for a lack of both title and dismiss optionsTesting
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.