Skip to content

refactor(components): make title optional in ContentOverlay#2942

Closed
chris-at-jobber wants to merge 121 commits intomasterfrom
make-title-optional-in-contentoverlay
Closed

refactor(components): make title optional in ContentOverlay#2942
chris-at-jobber wants to merge 121 commits intomasterfrom
make-title-optional-in-contentoverlay

Conversation

@chris-at-jobber
Copy link
Copy Markdown
Contributor

@chris-at-jobber chris-at-jobber commented Mar 3, 2026

Motivations

For cases where a consumer may want to provide their own title, or NO title, the title prop can be optional (similar to the Modal component in web, or the BottomSheet component in mobile).

When a title is not passed and there is no dismiss option, the header section should be empty and not take up vertical space within the ContentOverlay.

Changes

Changed

  • Made the title property optional and updated the renderHeader to account for a lack of both title and dismiss options

Testing

Changes can be
tested via Pre-release


In Atlantis we use Github's built in pull request reviews.

jdeichert and others added 19 commits December 8, 2025 12:07
…bottom-sheet-and-replace-react-native-modalize' into JOB-140606-implement-it-in-content-overlay
We realized this file is actually exported as part of our package, so that's why reanimated's mock was duplicated between this file and __mocks.ts.

Restored that and moved `require("react-native-reanimated").setUpTests()` to our __mocks.ts file.
* deprecate legacy prop

* update props

* fully removed unused props
* uninstall modalize

* sync lockfile with npm i

* remove Modalize reference in override
* add ContentOverlayProvider, integrate with InputText to handle keyboard interactions

* avoid TS error, fix mock, add keyboard config props

* remove redundant test

* use interactive to prevent issues when no snap points

* prevent drag/pan in new way, always provide snap points to fix keyboard dismiss restoration

* add context for our single snap point entry

* use simpler callback for onClose

* add a couple tests

* handle large screen modal flow

* remove unnecessary ContentOverlay useEffect

* update draggable logic and comments

* replace provider in tests

* remove low value tests
…rity (#2884)

* add behavior computation module with tests, implement in ContentOverlay

* clean up tests

* update spelling for consistency

* update logic to mirror existing

* revert back to position for top logic
…oller (#2889)

* add RNKC, use to fix SV issues in ContentOverlay

* prevent ts errors in mocks

* provide override for RNKC package

* add additional mocks for site

* add aliases for RN packages to avoid vite failures

* revert aliases, use exernal instead

* surgically correct package-lock state

* update package-lock dep locations
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 3, 2026

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6a89642
Status: ✅  Deploy successful!
Preview URL: https://5d55c22d.atlantis.pages.dev
Branch Preview URL: https://make-title-optional-in-conte.atlantis.pages.dev

View logs

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2026

Published Pre-release for 6a89642 with versions:

  - @jobber/components@6.101.5-make-title-6a89642.114+6a896429a
  - @jobber/components-native@0.89.5-make-title-6a89642.114+6a896429a
  - @jobber/design@0.89.2-make-title-6a89642.154+6a896429a

To install the new version(s) for Web run:

npm install @jobber/components@6.101.5-make-title-6a89642.114+6a896429a @jobber/design@0.89.2-make-title-6a89642.154+6a896429a

To install the new version(s) for Mobile run:

npm install @jobber/components-native@0.89.5-make-title-6a89642.114+6a896429a @jobber/design@0.89.2-make-title-6a89642.154+6a896429a

Base automatically changed from JOB-140606-implement-it-in-content-overlay to master March 30, 2026 14:28
@chris-at-jobber
Copy link
Copy Markdown
Contributor Author

Michael got this sorted 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants